-
Notifications
You must be signed in to change notification settings - Fork 106
implement linked test cases content #4322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/test-library
Are you sure you want to change the base?
Conversation
|
app/src/pages/inside/productVersionPage/linkedTestCasesTab/tagList/tagList.jsx
Show resolved
Hide resolved
</Button> | ||
)} | ||
</div> | ||
{count > 0 && !isExpanded ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move to a variable count > 0 && !isExpanded
return; | ||
} | ||
|
||
const timeoutId = setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's write a comment to explain why we do it
defaultVersion: 'Password changing 2.1', | ||
setDefault: { | ||
component: ( | ||
<Button className={cx('table-cell__default-button')} icon={<FlagIcon />} variant={'text'}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Button className={cx('table-cell__default-button')} icon={<FlagIcon />} variant={'text'}> | |
<Button className={cx('table-cell__default-button')} icon={<FlagIcon />} variant="text"> |
Check similar cases in PR
|
||
const tagsShort = ['iOS System', 'iOS System Functionality Test']; | ||
|
||
export const getData = () => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be just a variable instead of function
PR Checklist
develop
for features/bugfixes, other if mentioned in the task)npm run lint
) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build
)?dev
npm script)manage:translations
script?Visuals
With active filter