Skip to content

implement linked test cases content #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feature/test-library
Choose a base branch
from

Conversation

OleksandrDragun
Copy link

@OleksandrDragun OleksandrDragun commented Apr 24, 2025

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you checked that no new circular dependencies appreared with your changes? (the webpack plugin reports circular dependencies within the dev npm script)
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?
  • Have you added the link to the PR in the Jira ticket comments?

Visuals

image
With active filter
image

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

</Button>
)}
</div>
{count > 0 && !isExpanded ? (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to a variable count > 0 && !isExpanded

return;
}

const timeoutId = setTimeout(() => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's write a comment to explain why we do it

defaultVersion: 'Password changing 2.1',
setDefault: {
component: (
<Button className={cx('table-cell__default-button')} icon={<FlagIcon />} variant={'text'}>
Copy link

@ViktorSoroka07 ViktorSoroka07 May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Button className={cx('table-cell__default-button')} icon={<FlagIcon />} variant={'text'}>
<Button className={cx('table-cell__default-button')} icon={<FlagIcon />} variant="text">

Check similar cases in PR


const tagsShort = ['iOS System', 'iOS System Functionality Test'];

export const getData = () => [
Copy link

@ViktorSoroka07 ViktorSoroka07 May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be just a variable instead of function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants