Feature/epmrpp 98957 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlebkanonik
approved these changes
Jan 31, 2025
raikbitters
approved these changes
Jan 31, 2025
|
merged to develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the release workflow for the service/index (Go) to align with the latest project requirements. Key updates include:
Dynamic service_name Support:
The workflow now accepts a dynamic service_name input, enabling compatibility with services using the service-* prefix.
In this case, it specifically targets service/index, ensuring consistent artifact naming and publishing.
Branch Validation and Checkout:
The workflow ensures that all processes are executed exclusively on the master branch.
Removed redundant branch validation as the checkout step is explicitly configured to always use master.
Artifact Generation and Upload Improvements:
Adjustments have been made to ensure artifacts are named using the correct release tag (release_version).
Enhanced error handling to prevent conflicts when an artifact with the same name already exists in the release.
Robust Tag and Release Management:
Ensures consistency between the release tag and the generated artifacts.
Artifacts are only uploaded when they match the active release tag.
How to Use
Create a release with a tag associated with the service/index.
Verify that the workflow builds the binary correctly and uploads it as an artifact to the release.
Confirm that the uploaded artifact follows the expected naming convention: service-index-<release_version>.release.
Important Notes
This PR introduces a more flexible and scalable process to support additional services in the future.
It ensures that the service/index is fully integrated with the dynamic release workflow.