feat: Allow token auth age to be disabled #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ML_TOKEN_AGE_CHECK This validation is enabled by default, so reportportal must be explicitly configured to disable this check
nabeelpaytrix
force-pushed
the
feat/allow-sso-token-age-auth-to-be-disabled
branch
from
7dcfe35 to
fafa07b
Compare
|
|
Also waiting for a way to handle this issue - will be happy to test this workaround. |
| import static org.springframework.security.saml.util.DateUtils.toZuluTime; | ||
| import static org.springframework.util.StringUtils.hasText; | ||
|
|
||
| public class CustomValidator extends DefaultValidator { |
There was a problem hiding this comment.
In case you implement CustomValidator, why not change maxAuthenticationAgeMillis to long in your implementation?
There are not many usages inside the DefaultValidator
https://jar-download.com/artifacts/org.springframework.security.extensions/spring-security-saml2-core/2.0.0.M31/source-code/org/springframework/security/saml/spi/DefaultValidator.java
|
Any tentative timeline for this feature to be enable??? Appreciate your inputs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disable can be via env variable RP_AUTH_SAML_TOKEN_AGE_CHECK
This validation is enabled by default, so reportportal must be explicitly configured to disable this check
Github Issue: #361