Skip to content

Orgs login migration #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 25, 2025
Merged

Orgs login migration #2238

merged 23 commits into from
Apr 25, 2025

Conversation

raikbitters
Copy link
Member

@raikbitters raikbitters commented Apr 24, 2025

This pull request introduces various changes to streamline user management and event handling in the codebase. The changes include removing unused fields and methods, simplifying logic for user creation and password reset, and improving email normalization. Below are the most significant updates, grouped by theme:

Event Handling Simplifications:

  • Removed the projectId field and associated logic from the CreateInvitationLinkEvent class, as it is no longer required. (CreateInvitationLinkEvent.java, [1] [2]

User Creation and Password Management:

  • Simplified the createUserByAdmin method in CreateUserHandlerImpl by removing redundant validations and directly normalizing email using EmailRulesValidator.NORMALIZE_EMAIL. (CreateUserHandlerImpl.java, src/main/java/com/epam/ta/reportportal/core/user/impl/CreateUserHandlerImpl.javaL130-R129)
  • Refactored the createRestorePasswordBid and resetPassword methods to streamline logic, replacing manual validations with reusable normalization and validation utilities. (CreateUserHandlerImpl.java, [1] [2]
  • Consolidated the saveUser method to remove unnecessary user activity handling and focus on core user creation logic. (CreateUserHandlerImpl.java, [1] [2]

Code Cleanup:

  • Removed unused imports, constants, and methods across multiple files, including CreateUserHandlerImpl and EditUserHandlerImpl, to reduce clutter and improve readability. (CreateUserHandlerImpl.java, [1]; EditUserHandlerImpl.java, [2]
  • Added missing punctuation in class-level comments for consistency. (CreateUserHandlerImpl.java, [1]; EditUserHandlerImpl.java, [2]

Constructor Improvements:

These changes collectively enhance code clarity, maintainability, and functionality in user management and event handling workflows.

@raikbitters raikbitters merged commit 6fde3bf into feature/orgs Apr 25, 2025
8 checks passed
@raikbitters raikbitters deleted the feature/orgs-login-migration branch April 25, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants