-
Notifications
You must be signed in to change notification settings - Fork 66
Orgs login migration #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Orgs login migration #2238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user login assignment to use email
…otations for boilerplate code reduction
…idation documentation
…line user creation logic
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java
Show resolved
Hide resolved
src/main/java/com/epam/ta/reportportal/model/user/CreateUserRQ.java
Outdated
Show resolved
Hide resolved
…readability and organization
src/test/java/com/epam/ta/reportportal/core/user/impl/CreateUserHandlerImplTest.java
Show resolved
Hide resolved
src/test/java/com/epam/ta/reportportal/core/user/impl/EditUserHandlerImplTest.java
Show resolved
Hide resolved
grabsefx
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces various changes to streamline user management and event handling in the codebase. The changes include removing unused fields and methods, simplifying logic for user creation and password reset, and improving email normalization. Below are the most significant updates, grouped by theme:
Event Handling Simplifications:
projectId
field and associated logic from theCreateInvitationLinkEvent
class, as it is no longer required. (CreateInvitationLinkEvent.java
, [1] [2]User Creation and Password Management:
createUserByAdmin
method inCreateUserHandlerImpl
by removing redundant validations and directly normalizing email usingEmailRulesValidator.NORMALIZE_EMAIL
. (CreateUserHandlerImpl.java
, src/main/java/com/epam/ta/reportportal/core/user/impl/CreateUserHandlerImpl.javaL130-R129)createRestorePasswordBid
andresetPassword
methods to streamline logic, replacing manual validations with reusable normalization and validation utilities. (CreateUserHandlerImpl.java
, [1] [2]saveUser
method to remove unnecessary user activity handling and focus on core user creation logic. (CreateUserHandlerImpl.java
, [1] [2]Code Cleanup:
CreateUserHandlerImpl
andEditUserHandlerImpl
, to reduce clutter and improve readability. (CreateUserHandlerImpl.java
, [1];EditUserHandlerImpl.java
, [2]CreateUserHandlerImpl.java
, [1];EditUserHandlerImpl.java
, [2]Constructor Improvements:
EditUserHandlerImpl
with detailed parameter descriptions for better maintainability. (EditUserHandlerImpl.java
, src/main/java/com/epam/ta/reportportal/core/user/impl/EditUserHandlerImpl.javaR101-R111)These changes collectively enhance code clarity, maintainability, and functionality in user management and event handling workflows.