Skip to content

EPMRPP-90160 OrganizationController refactoring #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 15, 2024
Merged

EPMRPP-90160 OrganizationController refactoring #1989

merged 7 commits into from
May 15, 2024

Conversation

grabsefx
Copy link
Contributor

No description provided.

@grabsefx grabsefx requested a review from avarabyeu as a code owner May 14, 2024 18:04
@grabsefx grabsefx self-assigned this May 14, 2024
github-actions[bot]
github-actions bot reviewed May 14, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/main/java/com/epam/ta/reportportal/demodata/DemoDataController.java|59 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/main/java/com/epam/ta/reportportal/util/ProjectExtractor.java|90| Line is longer than 100 characters (found 104).
src/main/java/com/epam/ta/reportportal/util/SlugifyUtils.java|5 col 1| Missing a Javadoc comment.
src/main/java/com/epam/ta/reportportal/model/project/CreateProjectRQ.java|55 col 1| Line contains a tab character.
src/main/java/com/epam/ta/reportportal/model/user/UserResource.java|75 col 3| Missing a Javadoc comment.
src/main/java/com/epam/ta/reportportal/model/user/UserResource.java|89 col 3| Missing a Javadoc comment.
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|104| Line is longer than 100 characters (found 115).
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|104 col 1| Line contains a tab character.
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|105 col 1| Line contains a tab character.
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|105 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|106| Line is longer than 100 characters (found 109).
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|106 col 1| Line contains a tab character.
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|174| Line is longer than 100 characters (found 111).
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|174 col 1| Line contains a tab character.
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|176 col 1| Line contains a tab character.
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|176 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|177| Line is longer than 100 characters (found 119).
src/main/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImpl.java|177 col 1| Line contains a tab character.
src/main/java/com/epam/ta/reportportal/core/project/impl/UpdateProjectHandlerImpl.java|177 col 81| Abbreviation in name 'updateProjectRQ' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/ta/reportportal/core/project/impl/UpdateProjectHandlerImpl.java|218 col 81| Abbreviation in name 'unassignUsersRQ' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/ta/reportportal/core/project/impl/UpdateProjectHandlerImpl.java|246 col 77| Abbreviation in name 'assignUsersRQ' must contain no more than '1' consecutive capital letters.
src/main/java/com/epam/ta/reportportal/core/organization/GetOrganizationHandler.java|25| Summary javadoc is missing.
src/main/java/com/epam/ta/reportportal/core/organization/GetOrganizationHandler.java|30| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/ta/reportportal/core/organization/GetOrganizationHandler.java|39| First sentence of Javadoc is missing an ending period.
src/main/java/com/epam/ta/reportportal/core/organization/GetOrganizationHandler.java|45| Line continuation have incorrect indentation level, expected level should be 4.
src/main/java/com/epam/ta/reportportal/core/organization/impl/GetOrganizationHandlerImpl.java|37| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/ws/converter/converters/UserConverterTest.java|54| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/ws/controller/OrganizationControllerTest.java|25| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|99 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|99 col 9| 'method def modifier' has incorrect indentation level 8, expected level should be 2.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|100 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|101 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|101 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|102 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|102 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|103 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|103 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|106 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|106 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|107 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|108| Line is longer than 100 characters (found 112).
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|108 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|109| Line is longer than 100 characters (found 123).
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|109 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|109 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|110 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|110 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|111 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/ws/controller/ProjectControllerTest.java|111 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/OrganizationUtil.java|23| Summary javadoc is missing.
src/test/java/com/epam/ta/reportportal/core/item/impl/UpdateTestItemHandlerImplTest.java|212| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|80| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|80 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|97| Line is longer than 100 characters (found 115).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|97 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|100| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|100 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|119| Line is longer than 100 characters (found 137).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|119 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|122| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|138| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|138 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|146| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|146 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|163| Line is longer than 100 characters (found 141).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|163 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|172| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|172 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|194| Line is longer than 100 characters (found 119).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|194 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|197| Line is longer than 100 characters (found 123).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|197 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|213 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|214| Line is longer than 100 characters (found 122).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|214 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|223| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|223 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226| Line is longer than 100 characters (found 135).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|226 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|242 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|252 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|272 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282| Line is longer than 100 characters (found 142).
src/test/java/com/epam/ta/reportportal/core/item/impl/GetTestItemHandlerImplTest.java|282 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/item/impl/StartTestItemHandlerImplTest.java|161| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/analyzer/auto/impl/SearchLogServiceImplTest.java|92| Line is longer than 100 characters (found 103).
src/test/java/com/epam/ta/reportportal/core/project/settings/impl/CreateProjectSettingsHandlerImplTest.java|71| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/project/settings/impl/DeleteProjectSettingsHandlerImplTest.java|63| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java|135| Line is longer than 100 characters (found 147).
src/test/java/com/epam/ta/reportportal/core/project/impl/GetProjectHandlerImplTest.java|135 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|114 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|114 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|116 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|116 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|118| Line is longer than 100 characters (found 146).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|118 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|118 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|125 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|125 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|128| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|128 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|128 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|131| Line is longer than 100 characters (found 146).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|131 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|131 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|141| Line is longer than 100 characters (found 143).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|141 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|141 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|144| Line is longer than 100 characters (found 152).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|144 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|144 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|151 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|151 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|155| Line is longer than 100 characters (found 138).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|155 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|155 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|161| Line is longer than 100 characters (found 146).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|161 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|161 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|168 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|168 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|181 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|181 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|182| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|182 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|182 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|188| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|188 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|188 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193| Line is longer than 100 characters (found 138).
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|193 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|199 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/project/impl/DeleteProjectHandlerImplTest.java|199 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/launch/impl/GetLaunchHandlerImplTest.java|238| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/UpdateLaunchHandlerImplTest.java|161| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|97| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|118| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/launch/impl/FinishLaunchHandlerImplTest.java|164| Line is longer than 100 characters (found 102).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|86| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|114| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/filter/impl/UpdateUserFilterHandlerTest.java|146| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|122 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|130 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|139 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|158 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166| Line is longer than 100 characters (found 101).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 1| Line contains a tab character.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|166 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|175 col 9| 'TEST_PROJECT_KEY' has incorrect indentation level 8, expected level should be 20.
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182| Line is longer than 100 characters (found 139).
src/test/java/com/epam/ta/reportportal/core/integration/impl/DeleteIntegrationHandlerTest.java|182 col 1| Line contains a tab character.

src/main/java/com/epam/ta/reportportal/ws/converter/converters/UserConverter.java Outdated
.stream()
.collect(Collectors.toMap(orgUser -> orgUser.getOrganization().getSlug(),
orgUser -> {
UserResource.AssignedOrganization assignedOrganization = new UserResource.AssignedOrganization();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 113).

src/main/java/com/epam/ta/reportportal/ws/converter/converters/OrganizationConverter.java
import com.epam.ta.reportportal.model.OrganizationProfile;
import java.util.function.UnaryOperator;

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java Outdated

import com.epam.ta.reportportal.entity.organization.OrganizationFilter;
import com.epam.ta.reportportal.model.OrganizationProfile;
import com.epam.ta.reportportal.commons.ReportPortalUser;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'com.epam.ta.reportportal.commons.ReportPortalUser' import. Should be before 'com.epam.ta.reportportal.model.OrganizationProfile'.

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java Outdated
import com.epam.ta.reportportal.entity.organization.OrganizationFilter;
import com.epam.ta.reportportal.model.OrganizationProfile;
import com.epam.ta.reportportal.commons.ReportPortalUser;
import com.epam.ta.reportportal.commons.querygen.CompositeFilter;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'com.epam.ta.reportportal.commons.querygen.CompositeFilter' import. Should be before 'com.epam.ta.reportportal.model.OrganizationProfile'.

src/main/java/com/epam/ta/reportportal/ws/controller/OrganizationController.java Outdated
import com.epam.ta.reportportal.model.OrganizationProfile;
import com.epam.ta.reportportal.commons.ReportPortalUser;
import com.epam.ta.reportportal.commons.querygen.CompositeFilter;
import com.epam.ta.reportportal.commons.querygen.Condition;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'com.epam.ta.reportportal.commons.querygen.Condition' import. Should be before 'com.epam.ta.reportportal.model.OrganizationProfile'.

src/main/java/com/epam/ta/reportportal/auth/permissions/Permissions.java Outdated
public static final String PROJECT_MANAGER_OR_ADMIN = "hasPermission(#projectKey.toLowerCase(), 'projectManagerPermission')" + "||" + ADMIN_ONLY;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 147).

src/main/java/com/epam/ta/reportportal/demodata/DemoDataController.java Outdated
@@ -50,8 +54,8 @@ class DemoDataController {

@PostMapping("/generate")
@Operation(summary = "generate")
public DemoDataRs generate(@PathVariable String projectName, @Validated @RequestBody DemoDataRq demoDataRq,
public DemoDataRs generate(@PathVariable String projectKey, @Validated @RequestBody DemoDataRq demoDataRq,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 114).

src/main/java/com/epam/ta/reportportal/demodata/DemoDataController.java Outdated
@@ -50,8 +54,8 @@ class DemoDataController {

@PostMapping("/generate")
@Operation(summary = "generate")
public DemoDataRs generate(@PathVariable String projectName, @Validated @RequestBody DemoDataRq demoDataRq,
public DemoDataRs generate(@PathVariable String projectKey, @Validated @RequestBody DemoDataRq demoDataRq,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

src/main/java/com/epam/ta/reportportal/demodata/DemoDataController.java Outdated
@AuthenticationPrincipal ReportPortalUser user) {
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectName), user);
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectKey), user);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 129).

src/main/java/com/epam/ta/reportportal/demodata/DemoDataController.java Outdated
@AuthenticationPrincipal ReportPortalUser user) {
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectName), user);
return demoDataService.generate(demoDataRq, projectExtractor.extractProjectDetailsAdmin(user, projectKey), user);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

@grabsefx grabsefx changed the base branch from develop to feature/orgs May 14, 2024 18:05
APiankouski
APiankouski reviewed May 15, 2024
View reviewed changes
project-properties.gradle
@@ -16,7 +16,7 @@ project.ext {
isDebugMode = System.getProperty("DEBUG", "false") == "true"
releaseMode = project.hasProperty("releaseMode")
scriptsUrl = commonScriptsUrl + (releaseMode ? '5.11.0' : 'develop')
migrationsUrl = migrationsScriptsUrl + (releaseMode ? '5.11.0' : 'develop')
migrationsUrl = migrationsScriptsUrl + (releaseMode ? '5.11.0' : 'EPMRPP-90160')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change to develop as EPMRPP-90160 branch was merged

@grabsefx grabsefx merged commit b26504c into feature/orgs May 15, 2024
8 checks passed
@grabsefx grabsefx deleted the EPMRPP-90160 branch May 15, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@APiankouski APiankouski APiankouski left review comments

@pbortnik pbortnik pbortnik approved these changes

@avarabyeu avarabyeu Awaiting requested review from avarabyeu

Assignees

@grabsefx grabsefx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grabsefx @pbortnik @APiankouski