fixed #2462 v9 continue support dragonfly, it's Hello command return "NOAUTH Authentication required" error #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinzhanguo
changed the title
|
We should maintain compatibility with redis, not If you need dragonfly, you can create a new warehouse based on go-redis to support /cc @vmihailenco |
|
If this is all that is needed to support DragonflyDB, then I am fine with keeping it. It is a tiny change that does not cost us anything. |
vmihailenco
reviewed
Mar 10, 2023
|
We accept this PR, but we do not guarantee compatibility with dragonfly. |
monkey92t
approved these changes
Mar 10, 2023
vmihailenco
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2462
dragonfly dont support hello command, it's return "NOAUTH Authentication required" when use Hello command.