zset member returned as an interface type instead of a string and is not type-safe

[Aden-Q]

Expected Behavior

According to the redis doc, zset members should always be strings. We want zset members to be returned as strings so that we don't have to do type assertion explicitly.

Current Behavior

zset member is returned as an interface:

go-redis/sortedset_commands.go

Line 730 in 21bd40a

Member interface{}

Possible Solution

Define the Z struct's member field as a string type:

go-redis/sortedset_commands.go

Lines 728 to 731 in 21bd40a

	type Z struct {
	Score float64
	Member interface{}
	}

Steps to Reproduce

Context (Environment)

Detailed Description

Possible Implementation

[szuecs]

@chayim why this was a bug?
I would expect a breaking change only happens at major version updates.

[chayim]

@szuecs Honest mistake frankly. Happens sometimes.

@ofekshenawa IMHO we need to revert accordingly and release a 9.4.0 due to this. I would minor the bugfix

If we feel this breaking matters - we can stack it up for future v10.

[ofekshenawa]

Absolutely, I agree. We plan to release version 9.4.0 this Sunday, which will include the necessary fix.

[szuecs]

Thanks!

[github-actions]

This issue is marked stale. It will be closed in 30 days if it is not updated.

[ndyakov]

So, this is still a breaking change and is Member is still an interface{}. Keeping this alive for v10