Skip to content

Drop FR manual exposures #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Drop FR manual exposures #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions reddit_decider/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,10 @@ def expose(
logger.info(str(exc))
return

# drop exposure for feature rollouts
if not feature.emit_event:
return

event_context_fields = self._decider_context.to_event_dict()
event_context_fields.update(exposure_kwargs or {})
event_fields = deepcopy(event_context_fields)
Expand Down
13 changes: 13 additions & 0 deletions tests/decider_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,19 @@ def test_expose(self):
experiment_name="exp_1", variant=variant, event_fields=event_fields
)

def test_feature_rollout_does_not_expose(self):
self.exp_base_config["exp_1"].update({"emit_event": False})

with create_temp_config_file(self.exp_base_config) as f:
decider = setup_decider(f, self.dc, self.mock_span, self.event_logger)

self.assertEqual(self.event_logger.log.call_count, 0)
variant = "variant_4"
decider.expose("exp_1", variant)

# exposure not fired
self.assertEqual(self.event_logger.log.call_count, 0)

def test_expose_without_variant_name(self):
with create_temp_config_file(self.exp_base_config) as f:
decider = setup_decider(f.name, self.dc, self.mock_span, self.event_logger)
Expand Down