Skip to content

Update get_experiment() to use decider shim & remove last decider bindings usage #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2023
Merged

Update get_experiment() to use decider shim & remove last decider bindings usage #90

merged 3 commits into from
Jan 12, 2023

Conversation

mrlevitas
Copy link
Contributor

By updating get_experiment() to use the shim's get_feature(), we eliminate the last dependency on the previous py bindings (accessed via get_decider()), and also add metrics to the function.

@mrlevitas mrlevitas merged commit 171b5fe into develop Jan 12, 2023
@mrlevitas mrlevitas deleted the get_exp_metrics branch January 12, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshipilov gshipilov gshipilov approved these changes

@wuyiqicc wuyiqicc Awaiting requested review from wuyiqicc

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrlevitas @gshipilov