Use rust_decider.RustDecider in get_variant() & get_variant_without_expose()
#79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrlevitas
force-pushed
the
use_RustDecider
branch
from
438265d to
e75666e
Compare
mrlevitas
force-pushed
the
use_RustDecider
branch
from
869bc8e to
ba939da
Compare
mrlevitas
commented
Dec 5, 2022
gshipilov
reviewed
Dec 6, 2022
mrlevitas
commented
Dec 7, 2022
tests/decider_tests.py
Outdated
Comment on lines
492
to
499
| 'Rust decider has initialization error: Decider initialization failed: Json error: "invalid type: string \\"1\\"' | ||
| 'rust_decider.init() has error: Decider initialization failed: Partially loaded decider: 1 features failed to load.' |
There was a problem hiding this comment.
@gshipilov until I incorporate de-structuring the hashmap of feature specific errors, we're currently losing error info, we're losing that info for now.
There was a problem hiding this comment.
Yup, I think this is ok. I'm assuming restructuring the partial error is gonna happen relatively soon, and we have some workarounds for this if we end up in an incident.
gshipilov
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr shows the updates required to incorporate the new decider python shims once they have been merged.
These changes have been tested locally but CI will not pass until the upstream decider-py PR is merged & new
reddit-deciderpackage has been released.Changes
Decider()constructor no longer takes a filewatcher param, since an instance of it should not update its experiment config json mid-request.Instead an instance of
rust_decider.RustDeciderclass is passed in, which was initialized by the filewatcher in theDeciderContextFactory.rust_decider.RustDecider#choose(), instead ofrust_decider.make_ctx()/rust_decider.choose()functions, inget_variant()/get_variant_without_expose()"Feature "{feature_name}" not found."once viawarnings.warn()to alleviate logs if the feature was disabled and not found in config (to maintain parity w/ reddit_experiments)