Skip to content

Move decider_client_from_config() back to reddit_decider dir #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2022

Conversation

mrlevitas
Copy link
Contributor

I was able to import from reddit_decider import decider_client_from_config with version v1.0.3-alpha (prior to this update) in experiment-config server so I'm moving this fn back with the rest of decider stuff.

@wuyiqicc
Copy link
Contributor

The thing is that developers integrate, do they have to import both reddit-decider and reddit-experiments? It is a bit confusing not to put the interfaces together.

@mrlevitas
Copy link
Contributor Author

The thing is that developers integrate, do they have to import both reddit-decider and reddit-experiments? It is a bit confusing not to put the interfaces together.

Just the latter package (reddit-experiments, this sdk) is required for devs.
reddit-decider is a dependency of this sdk and will get pulled in, but that's not the same as what we're importing here via from reddit_decider import decider_client_from_config.
reddit_decider in the import statement is the module (i think that's the correct term) within reddit-experiments package.

@mrlevitas mrlevitas merged commit 7495998 into develop Apr 28, 2022
@mrlevitas mrlevitas deleted the decider_from_client branch April 28, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants