Skip to content

fix T TypeVar #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2023
Merged

fix T TypeVar #106

merged 3 commits into from
Jun 20, 2023

Conversation

mrlevitas
Copy link
Contributor

@mrlevitas mrlevitas commented Jun 15, 2023 •
edited
Loading

#Summary

  • fix bug where we use from baseplate.lib.file_watcher import T to define a generic type, instead of defining it in the file

@mrlevitas mrlevitas force-pushed the update_DeciderContext branch from 88cb308 to e4600b3 Compare June 15, 2023 06:31
@mrlevitas mrlevitas requested a review from aleksgapp June 15, 2023 07:33
@mrlevitas mrlevitas changed the title Expose subreddit_id fix T TypeVar Jun 17, 2023
@mrlevitas mrlevitas merged commit 635a5b3 into develop Jun 20, 2023
@mrlevitas mrlevitas deleted the update_DeciderContext branch June 20, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksgapp aleksgapp aleksgapp approved these changes

@gshipilov gshipilov gshipilov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrlevitas @aleksgapp @gshipilov