Skip to content

Add a Portal component #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2017
Merged

Add a Portal component #18

merged 1 commit into from
Sep 25, 2017

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Sep 22, 2017

react-component/trigger#69

用来代替原有的 getContainerRenderMixin

@benjycui
Copy link
Member

benjycui commented Sep 25, 2017 •
edited
Loading

其实不大建议沉淀这个组件，毕竟代码量也不大，而且 rc-util 发新版后，需要把所有使用到 rc-util 的组件都升级依赖，不然会出现之前的那种奇怪的版本冲突。。

Edit: 理由不充分

@yesmeck
Copy link
Member Author

yesmeck commented Sep 25, 2017

囧

@yesmeck
Copy link
Member Author

yesmeck commented Sep 25, 2017

目前 rc-trigger 和 rc-dialog 需要用到这个。

@yesmeck yesmeck merged commit db4c433 into master Sep 25, 2017
@yesmeck yesmeck deleted the portal branch September 25, 2017 06:11
@benjycui
Copy link
Member

4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjycui benjycui benjycui approved these changes

@yiminghe yiminghe Awaiting requested review from yiminghe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yesmeck @benjycui