-
-
Notifications
You must be signed in to change notification settings - Fork 233
Support React 16 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Support React 16 #69
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import React from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import { createPortal } from 'react-dom'; | ||
|
||
export default class Portal extends React.Component { | ||
static propTypes = { | ||
getContainer: PropTypes.func.isRequired, | ||
children: PropTypes.node.isRequired, | ||
} | ||
|
||
componentDidMount() { | ||
this.createContainer(); | ||
} | ||
|
||
componentWillUnmount() { | ||
this.removeContainer(); | ||
} | ||
|
||
createContainer() { | ||
this._container = this.props.getContainer(); | ||
this.forceUpdate(); | ||
} | ||
|
||
removeContainer() { | ||
if (this._container) { | ||
this._container.parentNode.removeChild(this._container); | ||
} | ||
} | ||
|
||
render() { | ||
if (this._container) { | ||
return createPortal(this.props.children, this._container); | ||
} | ||
return null; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afc163 FYI,getPopupContainer 之类的 API,其实只会调用一次,并且之前一直就是这样。考虑到有 removeContainer 的需要,getPopupContainer 的确只能调用一次。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没懂,有啥问题。
如果父元素 dom 结构变了,可能需要调用多次吧。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不缓存 getPopupContainer 的返回值其实也可以,只是每次 render 都需要对比当前返回值和之前的返回值,并相应的 mount unmount 节点。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
并且这样就要求用户的 getPopupContainer 必须稳定,不能出现以下的情况:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样就是 breaking changes 了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个先保持原有的行为吧。