-
Notifications
You must be signed in to change notification settings - Fork 114
同步 master 分支的一些 bugfix 到 antd-v5 分支,以修复 antd@v5 的 bug #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
同步 master 分支的一些 bugfix 到 antd-v5 分支,以修复 antd@v5 的 bug #371
Conversation
…eact-component#365) * fix: some properties changed by useState are not work * test: add test (cherry picked from commit d315300)
* revert solution * fix again (cherry picked from commit 3b1e34b)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Walkthrough此次更改主要涉及通知组件的关闭按钮和相关接口。样式上,关闭按钮的 CSS 被调整,移除了边框并设置了白色背景。组件实现上,关闭按钮从 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NotificationAPI
participant NotificationComponent
User->>NotificationAPI: open({ closable: { closeIcon, ...ariaProps } })
NotificationAPI->>NotificationComponent: 渲染通知,传递 closable 对象
NotificationComponent->>NotificationComponent: 渲染 close button,应用 closeIcon 和 aria 属性
User->>NotificationComponent: 点击 close button
NotificationComponent->>NotificationAPI: 触发关闭逻辑
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This comment was marked as outdated.
This comment was marked as outdated.
b73fe15
to
68aedc6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #371 +/- ##
=========================================
Coverage 99.74% 99.74%
=========================================
Files 7 7
Lines 773 777 +4
Branches 125 125
=========================================
+ Hits 771 775 +4
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
新功能
closable
属性对象自定义关闭按钮图标,并可传递无障碍属性(aria 属性)到关闭按钮。样式
测试
closable
属性结构。