Skip to content

Mask password in "Added MAVEN property..." info messages / allow suppress the messages #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vlsi opened this issue Nov 29, 2015 · 5 comments
Assignees
Milestone

Comments

@vlsi
Copy link
Contributor

vlsi commented Nov 29, 2015

The list of valid variables is very helpful for initial usage of JCP, so it is good it is enabled by default.

However:

  1. It is not that safe to print all the properties (e.g. mvn.project.property.password, mvn.project.property.gpg.passphrase, etc). maven logs can be copy&pasted and it might lead to unexpected sharing of the passwords.

  2. It would be nice to have a configuration property to suppress that output (as it would no longer be required after JCP comments are in place)

@raydac raydac added this to the 6.0.1 milestone Nov 29, 2015
@raydac raydac self-assigned this Nov 29, 2015
@raydac
Copy link
Owner

raydac commented Nov 29, 2015

good point

@vlsi
Copy link
Contributor Author

vlsi commented Nov 29, 2015

Re 1, varName.toLower().contains("pass") || varName.toLower().contains("key") might be a good start.

@raydac
Copy link
Owner

raydac commented Nov 29, 2015

may be print them only in verbose mode?

@vlsi
Copy link
Contributor Author

vlsi commented Nov 29, 2015

may be print them only in verbose mode?

That will work provided it is documented in "quick start" section

raydac added a commit that referenced this issue Nov 29, 2015
…o hide info in *pass* and *key* properties (issue #2)
@raydac
Copy link
Owner

raydac commented Nov 29, 2015

I made some changes to hide potentially private properties content in maven log, 7b6fc2d

@raydac raydac closed this as completed Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants