Skip to content

Maven plugin fails if the source folder is missing #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
htfv opened this issue Jan 24, 2017 · 5 comments
Closed

Maven plugin fails if the source folder is missing #12

htfv opened this issue Jan 24, 2017 · 5 comments
Assignees
Milestone

Comments

@htfv
Copy link

htfv commented Jan 24, 2017

Typical Maven plugins skip missing source folders (compiler, resources, surefire, etc). This allows configuring them once in a parent POM or lifecyle. JCP fails the build if the source folder is missing.

Use case: we are using JCP in a big project with over 500 modules. Currently we define 2 executions: one for main and one for test sources. We want to configure JCP in the common parent POM to enable it in all modules by default, but it does not always work, because some modules do not have test sources.

Please make JCP Maven plugin ignore missing sources folders, or add a configuration parameter to ignore missing source folders.

I can implement the change and make a pull request if that will speed up things.

@raydac raydac self-assigned this Jan 24, 2017
@raydac
Copy link
Owner

raydac commented Jan 24, 2017

ok, I will check

@raydac raydac added this to the 6.1.1 milestone Jan 24, 2017
raydac added a commit that referenced this issue Jan 24, 2017
@raydac
Copy link
Owner

raydac commented Jan 24, 2017

I have added boolean parameter 'ignoreMissingSources' which is false by default

<ignoreMissingSources>true</ignoreMissingSources>

if such flag is set then missing source folders will be ignored and error will not be thrown

@htfv
Copy link
Author

htfv commented Jan 25, 2017

I tested it and it works. Thank you for quick response. When can we expect release?

@raydac
Copy link
Owner

raydac commented Jan 25, 2017

I have published the snapshot version in the snapshot repository (which described in readme), if all is ok and there are not new ideas and issues during one-two weeks then I will release the plugin in the maven central

@raydac
Copy link
Owner

raydac commented Feb 11, 2017

6.1.1 has been published in maven central

@raydac raydac closed this as completed Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants