Skip to content

[Data] Remove lazy fixture #51764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Bye-legumes
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: zhilong <[email protected]>
@Bye-legumes Bye-legumes requested a review from a team as a code owner March 27, 2025 18:39
@Bye-legumes
Copy link
Contributor Author

@richardliaw do I need add indirect?

@richardliaw
Copy link
Contributor

richardliaw commented Mar 27, 2025 via email

@richardliaw richardliaw added the data Ray Data-related issues label Mar 27, 2025
@Bye-legumes
Copy link
Contributor Author

I thinkyou need to do something like TvoroG/pytest-lazy-fixture#65 (comment)

On Thu, Mar 27, 2025 at 11:40 AM zhilong @.> wrote: @richardliaw https://github.com/richardliaw do I need add indirect? — Reply to this email directly, view it on GitHub <#51764 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCRZZMHFW2YB6UNZ4TJ5LD2WRAZBAVCNFSM6AAAAABZ5XZIM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJZGA3TOOBTGA . You are receiving this because you were mentioned.Message ID: @.> [image: Bye-legumes]Bye-legumes left a comment (ray-project/ray#51764) <#51764 (comment)> @richardliaw https://github.com/richardliaw do I need add indirect? — Reply to this email directly, view it on GitHub <#51764 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCRZZMHFW2YB6UNZ4TJ5LD2WRAZBAVCNFSM6AAAAABZ5XZIM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJZGA3TOOBTGA . You are receiving this because you were mentioned.Message ID: @.***>

Right, let me have another PR to fix this in that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-backlog data Ray Data-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants