Fix encryption when using clang, and with allocatable heap #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added a test build of pico-examples using latest clang, which would have caught this |
These segments are not necessary, and will likely be moved to invalid memory addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes encryption when using clang by plugging gaps between segments when encrypting, in addition to already plugging gaps between sections within segments when signing/hashing/encrypting.
Also fixes encryption with allocatable heap, by moving the signature block into the heap for no_flash binaries (as it already is with GCC), to ensure that the signature comes at the end of a contiguous region of defined data, as encryption currently requires a contiguous region. This will fix raspberrypi/pico-sdk#2515