Make Python re strings in tools/*.py be raw to avoid escape sequence warnings
#2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll convert this to draft, and we can come back to it (if necessary) after those other PRs are merged. |
will-v-pi
reviewed
Jun 17, 2025
| board_detection_is_next = True | ||
| continue | ||
|
|
||
| # check include-suggestion | ||
| m = re.match("^\s*// This header may be included by other board headers as \"(.+?)\"", line) | ||
| m = re.match(r"^\s*// This header may be included by other board headers as \"(.+?)\"", line) |
There was a problem hiding this comment.
This will give the raw string ^\s*// This ... as \"(.+?)\", but the desired result is ^\s*// This ... as "(.+?)" without the \ before the ". In my PR I worked around this using r""".....""" which avoids the need for escaping the ".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2529.
All
restrings intools/*.pyare now raw strings, to prevent warnings like:Also (fixed by accident due to my editor settings), some trailing whitespace was removed in the files I edited.