Clean extra output files #2504
Merged
Clean extra output files #2504
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add bin/uf2/dis/hex output files as byproducts, so they get cleaned up This is only best-effort, because BYPRODUCTS doesn't support generator expressions, so everything must be evaluated at the time pico_add_extra_outputs is called
kilograham
reviewed
Jun 18, 2025
kilograham
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bin/uf2/dis/hex output files as byproducts, so they get cleaned up when using
make clean(or similar)This is only best-effort, because
BYPRODUCTSdoesn't support generator expressions (https://gitlab.kitware.com/cmake/cmake/-/issues/12877), so everything must be evaluated at the timepico_add_extra_outputsis called. This shouldn't have any ill effects, other than not cleaning up the extra output files ifOUTPUT_NAMEis set after callingpico_add_extra_outputs.