vc4/hvs: Fix lbm size calculation for yuv #6012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was reducing the number of components by one when we were not blending with alpha. But that only makes sense if the components include alpha. For YUV, we were reducing the number of components for Y from one to zero which resulted in no lbm space being allocated. Fixes: #5912 Signed-off-by: Dom Cobley <[email protected]>
|
We're not anticipating any more 6.1 kernel builds (the next apt kernel update will be 6.6), so this branch is somewhat dead now. Do you have a reason why this is needed on 6.1, where moving to 6.6 is not wanted? |
|
Main reason is the fact that I already did quite a bit of testing with the 6.1 kernel for my software as well as the upcoming GPIO sysfs change I thought was part of that update. But I just realized that this isn't the case and I might just see if 6.6 is something I can use in the near future as well. Still having that fix in 6.1 would make it easier now, so I can defer the kernel update to my next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was reducing the number of components by one when we were not blending with alpha. But that only makes sense if the components include alpha.
For YUV, we were reducing the number of components for Y from one to zero which resulted in no lbm space being allocated.
Fixes: #5912