[4.1] fix cyclic dma setup and i2s parameters #1194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation of the number of required frames was wrong which could lead to the last frame being longer than the requested period length and even the maximum supported transfer size. eg when requesting a 88208 bytes buffer with a period len of 22052 (the defaults when playing a 44.1kHz stereo 16bit file with aplay) the code would allocate 3 frames, two with 22052 bytes and the last one with 44104 bytes instead of the expected 4 frames with 22052 bytes each. Signed-off-by: Matthias Reichl <[email protected]>
bcm2708-dmaengine supports a maximum transfer length of 32k bytes on the lite channels. period_bytes_max should reflect this limit. Signed-off-by: Matthias Reichl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport bcm2835 fixes in #1193 to bcm2708