bcm2835-camera.c error build 'vchiq_mmal_port_enable'

[mati75]

Hi,

On build 4.19.y it's return error on

gcc-8 -Wp,-MD,drivers/tty/.tty_port.o.d  -nostdinc -isystem /usr/lib/gcc/arm-linux-gnueabihf/8/include -I/<<PKGBUILDDIR>>/arch/arm/include -I./arch/arm/include/generated  -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/arm/include/uapi -I./arch/arm/incl
ude/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h  -I/<<PKGBUILDDIR>>/drivers/tty -Idrivers/tty -D__KERNEL__ -mlittle-endian -Wall -Wund
ef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -Werror-implicit-function-declaration -Wno-format-security -std=gnu89 -fno-PIE -DCC_HAVE_ASM_GOTO -fno-dwarf2-cfi-asm -fno-omit-frame-pointer -mapcs -mno-sched-prolog -fno-ipa-sra -mabi=
aapcs-linux -mfpu=vfp -funwind-tables -marm -Wa,-mno-warn-deprecated -D__LINUX_ARM_ARCH__=7 -march=armv7-a -msoft-float -Uarm -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-int-in-bool-context -O2 --param=allow-store-d
ata-races=0 -Wframe-larger-than=1024 -fstack-protector-strong -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-var-tracking-assignments -pg -Wdeclaration-after-statement -Wno-pointer-sign -Wno-stringop-trunc
ation -fno-strict-overflow -fno-merge-all-constants -fmerge-constants -fno-stack-check -fconserve-stack -Werror=implicit-int -Werror=strict-prototypes -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wno-
packed-not-aligned   -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -DKBUILD_BASENAME='"tty_port"' -DKBUILD_MODNAME='"tty_port"' -c -o drivers/tty/.tmp_tty_port.o /<<PKGBUILDDIR>>/drivers/tty/tty_port.c
/<<PKGBUILDDIR>>/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c: In function 'start_streaming':
/<<PKGBUILDDIR>>/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c:606:63: error: passing argument 3 of 'vchiq_mmal_port_enable' from incompatible pointer type [-Werror=incompatible-pointer-types]
      vchiq_mmal_port_enable(dev->instance, dev->capture.port, buffer_cb);
                                                               ^~~~~~~~~
In file included from /<<PKGBUILDDIR>>/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c:31:
/<<PKGBUILDDIR>>/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h:127:24: note: expected 'vchiq_mmal_buffer_cb' {aka 'void (*)(struct vchiq_mmal_instance *, struct vchiq_mmal_port *, int,  struct mmal_buffer *, long unsigned int,  unsigned int,  long long int,  
long long int)'} but argument is of type 'void (*)(struct vchiq_mmal_instance *, struct vchiq_mmal_port *, int,  struct mmal_buffer *)'
   vchiq_mmal_buffer_cb buffer_cb);
   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
  if [ "-pg" = "-pg" ]; then if [ drivers/tty/tty_port.o != "scripts/mod/empty.o" ]; then ./scripts/recordmcount  "drivers/tty/tty_port.o"; fi; fi;

[6by9]

Is that on a clean build and tree?
It all looks ok to me.
https://github.com/raspberrypi/linux/blob/rpi-4.19.y/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h#L45

typedef void (*vchiq_mmal_buffer_cb)(
		struct vchiq_mmal_instance  *instance,
		struct vchiq_mmal_port *port,
int status, struct mmal_buffer *buffer);

https://github.com/raspberrypi/linux/blob/rpi-4.19.y/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h#L130

int vchiq_mmal_port_enable(
		struct vchiq_mmal_instance *instance,
		struct vchiq_mmal_port *port,
vchiq_mmal_buffer_cb buffer_cb);

buffer_cb is https://github.com/raspberrypi/linux/blob/rpi-4.19.y/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c#L328

static void buffer_cb(struct vchiq_mmal_instance *instance,
		      struct vchiq_mmal_port *port,
		      int status,
struct mmal_buffer *mmal_buf)

and the call to vchiq_mmal_port_enable is https://github.com/raspberrypi/linux/blob/rpi-4.19.y/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c#L606

vchiq_mmal_port_enable(dev->instance, dev->capture.port, buffer_cb);

which all matches up.

Your error message looks dubious (added a couple of CRs for readability)

/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h:127:24: note: expected 
'vchiq_mmal_buffer_cb' {aka 'void (*)(struct vchiq_mmal_instance *, struct vchiq_mmal_port *, int, 
struct mmal_buffer *, long unsigned int,  unsigned int,  long long int, long long int)'}

a) the prototype of vchiq_mmal_port_enable is on line 130 of mmal-vchiq.h, not 127.
b) that's not the correct definition for vchiq_mmal_buffer_cb, almost as if mmal-vchiq.h is out of date.

[JamesH65]

Closing due to lack of activity. Please request to be reopened if you feel this issue is still relevant.