Skip to content

Support HTML Dialog Element #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Lasering opened this issue Sep 15, 2022 · 6 comments
Closed

Support HTML Dialog Element #85

Lasering opened this issue Sep 15, 2022 · 6 comments

Comments

@Lasering
Copy link
Contributor

The HTMLDialogElement has been added to scala-js-dom, it could also be added here.
@Lasering
Copy link
Contributor Author

Would a PR help?

@raquo
Copy link
Owner

raquo commented Nov 25, 2022 via email

@raquo
Copy link
Owner

raquo commented Dec 4, 2022

@Lasering Could you please add type Dialog = HTMLDialogElement to object html in scalajs-dom, it seems that all other HTML element types have an alias there.

@raquo
Copy link
Owner

raquo commented Dec 4, 2022

Sorry I'm just swamped with SDT / Laminar stuff myself.

raquo added a commit that referenced this issue Dec 4, 2022
@raquo
New: Add <dialog> tag. Fixes #85
ff31903
raquo added a commit that referenced this issue Dec 4, 2022
@raquo
New: Add <dialog> tag. Fixes #85
191463d
@Lasering
Copy link
Contributor Author

Lasering commented Dec 4, 2022

@Lasering Could you please add type Dialog = HTMLDialogElement to object html in scalajs-dom, it seems that all other HTML element types have an alias there.

In progress

@Lasering
Copy link
Contributor Author

The PR has been merged.

@raquo raquo closed this as completed in 9bd3737 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raquo @Lasering