Rewrite WebSockets code #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebSockets API has been completely re-done. Instead of splitting the WebSocket into sender and receiver and using exposed
mpsc
channels, everything is self contained. TheWebSocket
struct now itself implementsSink
andStream
.Fixes: #2
Fixes: #3
Inspired by: rustwasm/gloo#113
TODOs (potentially in future PRs)
AsyncRead
/AsyncWrite
forget
Closure
s - (WebSocket API leaks callbacks #2)