Skip to content

Fix always positive account.balance_in_cents #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frane
Copy link
Contributor

@frane frane commented Oct 20, 2020

Issue: balance_in_cents on accounts is always positive. In case of negative account balances, like when an account is in debt, this results in a wrong (positive) number being reported. See image.
issue

Reason: The sign is not applied to set_balance when the account balance is set from a statement.

Fix: Apply sign when setting account_balance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant