Skip to content

Remove needless webpack-cli installing #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions docs/switch_from_webpacker.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ If you would like to minimize the diff between Webpacker and jsbundling-rails:

## 2. Remove Webpacker

1. Delete the following files, ensuring that you've migrated any customizations you've done in them:
1. Delete the following files, ensuring that you've migrated any customizations you've done in them:

- `./bin/webpack`
- `./bin/webpack-dev-server`
Expand All @@ -75,13 +75,10 @@ If you would like to minimize the diff between Webpacker and jsbundling-rails:

## 3. Install dependencies

Webpacker includes [many dependencies](https://github.com/rails/webpacker/blob/5-x-stable/package.json) by default while jsbundling-rails leaves it to you. If you're only handling JavaScript with no modifications you'll only need to install `webpack-cli`. Treat the rest of this section ala-carte.
Webpacker includes [many dependencies](https://github.com/rails/webpacker/blob/5-x-stable/package.json) by default while jsbundling-rails leaves it to you. If you're only handling JavaScript with no modifications you don't need to install additional packages. Treat the rest of this section ala-carte.

```sh
# From the CLI, add webpack-cli
yarn add webpack-cli

# Then remove Webpacker packages
# From the CLI, remove Webpacker packages
yarn remove @rails/webpacker webpack-dev-server
```

Expand Down