-
Notifications
You must be signed in to change notification settings - Fork 188
Use rake-compiler-dock v0.6.0 #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
74cd9e4
to
eec47c8
Compare
I think we should bump the gem version to 1.1 now too. |
@@ -22,7 +22,7 @@ Gem::Specification.new do |s| | |||
s.add_runtime_dependency 'mini_portile2', '~> 2.0' # Keep this version in sync with the one in extconf.rb ! | |||
s.add_development_dependency 'rake', '~> 10.4' | |||
s.add_development_dependency 'rake-compiler', '0.9.5' | |||
s.add_development_dependency 'rake-compiler-dock', '~> 0.5.1' | |||
s.add_development_dependency 'rake-compiler-dock', '0.6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it important to lock to this version specifically, instead of continuing to use ~>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'll change that.
@aharpervc Can you help with this PR? I could not build the Windows gem in this branch. |
@metaskills I just pulled and built on this branch and it seemed to work fine for me. Is there anything I can do to help? I did have to make sure to clear my tmp, pkg, and previous lib directories to allow all the pre-requisite libraries to build. |
@coderjoe So |
eec47c8
to
9261b3d
Compare
Yep! |
OK, let me try again. Can you share the gems you built? Also, just pushed v1.1.0 version bump in this PR. |
I already cleaned my working directory. I'll build again. :) |
What do you know, the build failed on second build... looking into it now. |
Cool, pushed up a few changes in anticipation. Nothing major. Thinking of changing this too --- a/Rakefile
+++ b/Rakefile
@@ -89,7 +89,7 @@ desc 'Build the windows binary gems per rake-compiler-dock'
task 'gem:windows' do
require 'rake_compiler_dock'
RakeCompilerDock.sh <<-EOT
- bundle && rake cross native gem RUBY_CC_VERSION=2.0.0:2.1.6:2.2.2:2.3.0 CFLAGS="-Wall"
+ bundle && rake cross native gem RUBY_CC_VERSION=2.4.0:2.3.0:2.2.2:2.1.6:2.0.0 CFLAGS="-Wall"
EOT |
Checking out for the night. Lemme know what you find. I'm doing a build locally too. Feel free to commit to this branch too. TTYT. |
It looks like the new version of rake-compiler-dock may have upgraded to a newer version of GCC. This is causing the libiconv build to optimize out an inline function that we need. I'm going to experiment with other explicit optimization settings for libiconv's build and see what happens. The symptom is an error similar to:
|
Fixes libiconv inline function "aliases2_lookup" being optimized out in more recent versions of gcc.
@metaskills I've pushed a change which seems to have fixed my local build. Do me a favor and give it a go on your machine at your leisure so we can verify it's not just "working for me". :) |
Doing that now! |
I am having a problem with
|
No description provided.