Run rabbit_registry boot step after pre_boot (backport #13381) (backport #13393)
#13394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The `rabbit_registry` boot step starts up the `rabbit_registry` gen server from `rabbit_common`. This is a registry somewhat similar to the feature flag registry - it's meant to protect an ETS table used for looking up implementers of behaviors. The registry and its ETS table should be available as early as possible: the step should enable external_infrastructure rather than require it. (cherry picked from commit 3867012) (cherry picked from commit 1005a30)
michaelklishin
added a commit
to rabbitmq/rabbitmq-delayed-message-exchange
that referenced
this pull request
Feb 28, 2025
There are no boot steps that might depend on the one defined by this plugin. References rabbitmq/rabbitmq-server#13394. Closes #298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rabbit_registryboot step starts up therabbit_registrygen server fromrabbit_common. This is a registry somewhat similar to the feature flag registry - it's meant to protect an ETS table used for looking up implementers of behaviors. The registry and its ETS table should be available as early as possible: the step should enable external_infrastructure rather than require it.This is a quick fix for #13352. The crash in #13352 occurs because the
databaseboot step runs before therabbit_registryand Khepri deletes transient queues for the local node on during init (and that operation reads from the registry).Fixes #13352
This is an automatic backport of pull request #13381 done by Mergify.
This is an automatic backport of pull request #13393 done by Mergify.