By @noxdafox: Revival of #9620 Pass the message to rabbit_backing_queue:discard callback #13374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behaviour was passing solely the message ID making queue implementations such as, for example, the priority one hard to fulfil. Signed-off-by: Matteo Cafasso <[email protected]> (cherry picked from commit 1f7a27c)
Signed-off-by: Matteo Cafasso <[email protected]> (cherry picked from commit facddb3)
michaelklishin
changed the title
12 tasks
kjnilsson
reviewed
Feb 20, 2025
| @@ -105,7 +105,7 @@ | |||
|
|
|||
| %% Called to inform the BQ about messages which have reached the | |||
| %% queue, but are not going to be further passed to BQ. | |||
| -callback discard(rabbit_types:msg_id(), pid(), state()) -> state(). | |||
| -callback discard(rabbit_types:basic_message(), pid(), state()) -> state(). | |||
There was a problem hiding this comment.
should this be mc:state() instead of rabbit_types:basic_message()?
There was a problem hiding this comment.
@noxdafox can you please see if you can refactor this to mc:state/0 and make it work for the deduplication plugin? rabbit_types:basic_message/0 is AMQP 0-9-1-specific so we'd prefer to use the more generic mc module (which is AMQP 1.0-inspired but works for all protocols).
Thank you!
There was a problem hiding this comment.
Will do. Will submit another PR.
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #12743 #9620 by @noxdafox rebased and re-submitted by me.