Use lambdas for *Listener objects #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A proposal to use lambdas in listeners objects. Some callback interfaces have been introduced when necessary (not necessary for e.g. ShutdownListener). Lambdas are wrapped into the original listener interfaces. Provide a simple test to experiment with the API. References #246
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) 2007-Present Pivotal Software, Inc. All rights reserved. | |||
| // Copyright (c) 2007-2017 Pivotal Software, Inc. All rights reserved. | |||
There was a problem hiding this comment.
I think we should leave it as Present.
|
This looks promising. |
|
@michaelklishin Thanks. Do you see anything to add/change? I was only thinking adding some Javadoc. |
|
Other than the docs we can add a few tests that use lambdas, that's it. |
Add functional interfaces for confirm, blocked, and return listeners. Fixes #246
michaelklishin
approved these changes
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal to use lambdas in listeners objects. Some callback
interfaces have been introduced when necessary (not necessary
for e.g. ShutdownListener). Lambdas are wrapped into the original
listener interfaces. Provide a simple test to experiment with the
API.
References #246