Skip to content

Log actor exit phase #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Log actor exit phase #5774

wants to merge 1 commit into from

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented May 21, 2025 •
edited
Loading

Description

Reorganize the actor exit logs:

  • explicit where the exit is coming from (initialization? hander? ...)
  • remove actor-failure logs (redundant with actor-exit)
  • remove redundant ?exit_status and cause?err as both contain the error for the ActorExitStatus::Failure(err) variant

How was this PR tested?

Example log lines:

2025-05-21T12:21:09.001Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id="SourceActor-morning-3QVF" phase=running exit_status=Killed

2025-05-21T12:21:09.035Z  INFO quickwit_actors::spawn_builder: actor-exit actor_id="Indexer-blue-M2W5" phase=handling(quickwit_actors::command::Command) exit_status=Success

@rdettai rdettai requested a review from fulmicoton-dd May 22, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton-dd fulmicoton-dd Awaiting requested review from fulmicoton-dd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rdettai