Skip to content

typst, template - remove non-valid brand.headings fields from typst template #12739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented May 15, 2025

Thanks @mcanouil for the report.

This PR is removing leftover from changes that happened in previous PR

Specifically,

  • brand.typography.headings.decoration and brand.typography.headings.heading-color were introduced
  • But they were also removed later in this same PR (13c8012 (#10974))
  • And a later commit (5e37696)

This PR removes the variables from typst template are they are not valid brand yaml option.

@cderv cderv requested review from gordonwoodhull and mcanouil May 15, 2025 09:18
@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented May 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link
Collaborator

@mcanouil mcanouil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you got them all.

Copy link
Contributor

@gordonwoodhull gordonwoodhull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cderv @mcanouil!

@cderv cderv merged commit a9eadac into main May 16, 2025
49 checks passed
@cderv cderv deleted the typst/brand-fix-heading branch May 16, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants