Bugfix/12167 pre: Figure label numbering for multiple figures not as subfigures #12516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #12167 , the behavior for multiple top-level figures together with a label is not optimal. This might be a step in the direction of allowing this feature, at least it provides a warning if this combination is used.
It works well in my setup but of course I only have a very limited view on the possibilities for crossref, figures, subfigures, multiple figures, and layouts.
The main idea is to check if
labelCellContainer === false
butsortedOutputs
is an array with more than 1 entry.This allows to:
Downside, the variable naming
labelCellContainer === false
implies no more labels which is than contradicted.Extended test cases
Provides the expected output and warnings.
Checklist
I have (if applicable):