Add new board to TOML & improve the board logic #439
Conversation
src/pyvec_docs/boards.toml
Outdated
| @@ -1,6 +1,34 @@ | |||
| # The Pyvec board members in time | |||
| # The current board is first, previous boards are listed in descending order | |||
| # Each member has a `name`, `github`, and optionally a `roles` array | |||
| # | |||
| # "start_on" should ideally be the date of the hand-over meeting | |||
There was a problem hiding this comment.
I think ideally it should be the same date as on justice.cz 🧑⚖️
There was a problem hiding this comment.
I think we need to clarify what the date means exactly. I think it should be the one which marks the power exchange officially, because after this gets merged, the votes of the board are effective under grants.
But I don't remember how the court works and what date they consider as the power exchange. If we provide the date to them, and if the date we provide is the date of the hand-over meeting, then it's the same date and your sentence in the YAML is correct 😅
|
Makes sense! (I plan to look at it next week.) |
|
I'm unsure if the grants and boards scripts are ready to work with empty start_on. But you can add the board with |
That said, I think they should be ok with a future start_on, so if you really need this merged now, you can put the date somewhere in the future and when we know the correct date, we can fix it. |
|
I'll adjust the scripts next week. |
|
The elections page wants the vote date, not the start date of the board that's currently in power. I also changed the ReST formatting for the table; hopefully it's now more readable. |
There was a problem hiding this comment.
Thanks for the code! I really like the different formatting of the table. I also like the new board being added to the TOML.
And I don't want to be a nuisance, but reading the diff, a question was popping up in my head and I couldn't get rid of it: Is adding a voted_on worth the added complexity we'll have to work around, test for, and maintain?
I think we should keep going with started_on and model the complicated world with this simple term. The page states that the official source of truth is justice.cz, so in fact we can have any date we like there. We can set it to the date of voting and once we know the official date of change, we can adjust it in a subsequent PR. I'd rather have the date slightly off for two months than to maintain two dates for the foreseeable future, document its meanings and burden the upcoming boards and maintainers with understanding the difference.
What do you think? I'm just a docs.pyvec.org gardener, and the operational docs should serve the board, so I feel really bad having so much comments about a single TOML change, I'm sorry for that 😞
src/pyvec_docs/boards.py
Outdated
| members: list[BoardMember] | ||
|
|
||
| model_config = {"extra": "forbid", "frozen": True} | ||
|
|
||
| @classmethod | ||
| def make(cls, voted_on=None, start_on=None, **kwargs): |
There was a problem hiding this comment.
This is first time I see a method like this called make, so I got confused what it does. Eventually I understood it's something I usually call create. I'm not strongly opinionated about this, just sharing that this was an effort for me to grasp, which might or might not mean anything.
|
The same question was popping up in my head :) I'll change this on ~Wednesday again. |
|
|
|
And I copied dates from justice.cz :) |
encukou
changed the title
No description provided.