-
Notifications
You must be signed in to change notification settings - Fork 363
feat: Add decorator utility to improve error messaging for legacy support #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
from enum import Enum | ||
from typing import List | ||
from typing import List, Callable | ||
from packaging import version | ||
|
||
# @manual=//deeplearning/trt/python:py_tensorrt | ||
import tensorrt as trt | ||
|
@@ -104,3 +105,36 @@ def f(*inp): | |
mod = run_const_fold(mod) | ||
mod = replace_op_with_indices(mod) | ||
return mod | ||
|
||
|
||
def req_torch_version(min_torch_version: str = "2.dev"): | ||
""" | ||
Create a decorator which verifies the Torch version installed | ||
against a specified version range | ||
|
||
Args: | ||
min_torch_version (str): The minimum required Torch version | ||
for the decorated function to work properly | ||
|
||
Returns: | ||
A decorator which raises a descriptive error message if | ||
an unsupported Torch version is used | ||
""" | ||
|
||
def nested_decorator(f: Callable): | ||
def function_wrapper(*args, **kwargs): | ||
# Parse minimum and current Torch versions | ||
min_version = version.parse(min_torch_version) | ||
current_version = version.parse(torch.__version__) | ||
|
||
if current_version < min_version: | ||
raise AssertionError( | ||
f"Expected Torch version {min_torch_version} or greater, " | ||
+ f"when calling {f}. Detected version {torch.__version__}" | ||
) | ||
Comment on lines
+131
to
+134
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The function |
||
else: | ||
return f(*args, **kwargs) | ||
|
||
return function_wrapper | ||
|
||
return nested_decorator |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default is "2.dev" since "2.0" is considered to be a larger version than "2.0.0.dev____".