Skip to content

Implement to_backend API #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
narendasan opened this issue Jun 3, 2020 · 4 comments · Fixed by #194
Closed

Implement to_backend API #82

narendasan opened this issue Jun 3, 2020 · 4 comments · Fixed by #194
Assignees
Milestone

Comments

@narendasan
Copy link
Collaborator

To backend API has landed in PyTorch master and will be released in PyTorch next, so we need to implement support.

@narendasan narendasan added this to the v0.1.0 milestone Jun 3, 2020
@narendasan narendasan self-assigned this Jun 3, 2020
@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

github-actions bot commented Aug 9, 2020

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@narendasan narendasan reopened this Oct 21, 2020
frank-wei pushed a commit that referenced this issue Jun 4, 2022
Summary:
Pull Request resolved: https://github.com/pytorch/fx2trt/pull/82

`check_mutable_operations` does not work.
We override `create_node` function to throw exception for inplace

Reviewed By: jfix71

Differential Revision: D36556398

fbshipit-source-id: db35732007eae77fb40500753d7ffe26d43e659c
mfeliz-cruise added a commit to mfeliz-cruise/Torch-TensorRT that referenced this issue Nov 30, 2022
# Description
The TensorRT topk layer requires at least 2 dimensions in the input tensor. Previously you would see this error for 1D inputs:
`ERROR: [Torch-TensorRT TorchScript Conversion Context] - 3: (Unnamed Layer* 74) [TopK]: at least 2 dimensions are required for input.`

This PR adds an unsqueeze for the inputs and corresponding squeeze for the outputs to workaround this limitation.

Fixes # (issue)

## Type of change

Please delete options that are not relevant and/or add your own.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update

# Checklist:

- [ ] My code follows the style guidelines of this project (You can use the linters)
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas and hacks
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests to verify my fix or my feature
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have added the relevant labels to my PR in so that relevant reviewers are notified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant