[hyperactor]: mailbox: CanSend for Mailbox use mailbox port for returns
#303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urns Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! [ghstack-poisoned]
shayne-fletcher
pushed a commit
that referenced
this pull request
Jun 18, 2025
…urns Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! ghstack-source-id: 291340611 Pull Request resolved: #303
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76926674 |
…ort for returns" Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! [ghstack-poisoned]
shayne-fletcher
pushed a commit
that referenced
this pull request
Jun 18, 2025
…urns Pull Request resolved: #303 the `CanSend` for `Mailbox` produces a self-bound `PortHandle` (allocating and binding only if needed). i don't have any immediate test coverage but removing `monitored_return_handle()` from this code is a definite and substantial improvement. ghstack-source-id: 291349747 Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)!
|
This pull request was exported from Phabricator. Differential Revision: D76926674 |
…ort for returns" Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! [ghstack-poisoned]
shayne-fletcher
pushed a commit
that referenced
this pull request
Jun 18, 2025
…urns Pull Request resolved: #303 the `CanSend` for `Mailbox` produces a self-bound `PortHandle` (allocating and binding only if needed). i don't have any immediate test coverage but removing `monitored_return_handle()` from this code is a definite and substantial improvement. ghstack-source-id: 291396595 Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)!
|
This pull request was exported from Phabricator. Differential Revision: D76926674 |
…ort for returns" Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! [ghstack-poisoned]
shayne-fletcher
pushed a commit
that referenced
this pull request
Jun 19, 2025
…urns Pull Request resolved: #303 the `CanSend` for `Mailbox` requires an undeliverable message port be self-bound. i don't have any immediate test coverage but removing `monitored_return_handle()` is a clear improvement. ghstack-source-id: 291398715 Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)!
|
This pull request was exported from Phabricator. Differential Revision: D76926674 |
…ort for returns" Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! [ghstack-poisoned]
shayne-fletcher
pushed a commit
that referenced
this pull request
Jun 19, 2025
…urns Pull Request resolved: #303 the `CanSend` for `Mailbox` requires an undeliverable message port be self-bound. i don't have any immediate test coverage but removing `monitored_return_handle()` is a clear improvement. ghstack-source-id: 291407170 Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)!
|
This pull request was exported from Phabricator. Differential Revision: D76926674 |
…ort for returns" Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! [ghstack-poisoned]
shayne-fletcher
pushed a commit
that referenced
this pull request
Jun 19, 2025
…urns Pull Request resolved: #303 the `CanSend` for `Mailbox` requires an undeliverable message port be self-bound. i don't have any immediate test coverage but removing `monitored_return_handle()` is a clear improvement. ghstack-source-id: 291418560 Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)!
|
This pull request was exported from Phabricator. Differential Revision: D76926674 |
…ort for returns" Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! [ghstack-poisoned]
shayne-fletcher
pushed a commit
that referenced
this pull request
Jun 19, 2025
…urns Pull Request resolved: #303 the `CanSend` for `Mailbox` requires an undeliverable message port be self-bound. i don't have any immediate test coverage but removing `monitored_return_handle()` is a clear improvement. ghstack-source-id: 291425647 Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)!
|
This pull request was exported from Phabricator. Differential Revision: D76926674 |
…ort for returns" Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! [ghstack-poisoned]
shayne-fletcher
pushed a commit
that referenced
this pull request
Jun 19, 2025
…urns Pull Request resolved: #303 the `CanSend` for `Mailbox` requires an undeliverable message port be self-bound. legacy tests were updated to be compliant with the new requirement. removing `monitored_return_handle()` from `CanSend` is a clear improvement. ghstack-source-id: 291502157 Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)!
|
This pull request was exported from Phabricator. Differential Revision: D76926674 |
…ort for returns" Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)! [ghstack-poisoned]
shayne-fletcher
pushed a commit
that referenced
this pull request
Jun 19, 2025
…urns Pull Request resolved: #303 the `CanSend` for `Mailbox` attempts to use a self-bound undeliverable message port and only falls back on `monitored_return_handle()` if one isn't bound. replacing unconditional use of `monitored_return_handle()` is a significant improvement. ghstack-source-id: 291503427 Differential Revision: [D76926674](https://our.internmc.facebook.com/intern/diff/D76926674/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76926674/)!
|
This pull request was exported from Phabricator. Differential Revision: D76926674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
CanSend for Mailboxuse mailbox port for returns #303Differential Revision: D76926674
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!