[monarch] spawn AsyncEndpointTask as a child #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were getting lots of warnings like: ``` W0617 10:43:15.339528 1781750 fbcode/monarch/hyperactor/src/proc.rs:1047] received signal for unknown child pid 18 ``` because we were doing `spawn` instead of `spawn_child`. Differential Revision: [D76833530](https://our.internmc.facebook.com/intern/diff/D76833530/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76833530/)! [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jun 17, 2025
we were getting lots of warnings like: ``` W0617 10:43:15.339528 1781750 fbcode/monarch/hyperactor/src/proc.rs:1047] received signal for unknown child pid 18 ``` because we were doing `spawn` instead of `spawn_child`. Differential Revision: [D76833530](https://our.internmc.facebook.com/intern/diff/D76833530/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D76833530/)! ghstack-source-id: 291027177 Pull Request resolved: #290
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76833530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
we were getting lots of warnings like:
because we were doing
spawninstead ofspawn_child.Differential Revision: D76833530
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!