Plumb actor supervision events into actor mesh #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76734454 |
Summary: Pull Request resolved: pytorch-labs#280 This diff pipes actor supervision events received in the proc mesh (for now) into the respective actor meshes. In order to do that, we have the following: 1) ActorMesh::next() which should be used to observe lifecycle events of the actor and handle them. (next diff does the actual lifecycle observer running in the background) and the handling logic. 2) ProcMesh should only react to unhandled supervision events that should appear as exactly that. Differential Revision: D76734454
|
This pull request was exported from Phabricator. Differential Revision: D76734454 |
vidhyav
force-pushed
the
export-D76734454
branch
from
9c6b972 to
a5bc98e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff pipes actor supervision events
received in the proc mesh (for now) into the respective actor
meshes. In order to do that, we have the following:
the actor and handle them. (next diff does the actual lifecycle
observer running in the background) and the handling logic.
that should appear as exactly that.
Differential Revision: D76734454