Create separate events for sending & receiving messages #250
+223
−212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76433477 |
|
This pull request was exported from Phabricator. Differential Revision: D76433477 |
thomasywang
pushed a commit
to thomasywang/monarch-1
that referenced
this pull request
Jun 12, 2025
…#250) Summary: Pull Request resolved: pytorch-labs#250 We have been treating the entire message send & recv as a single event but this doesn't really make sense since each of these should have their own duration (sending -> in flight -> receiving), and they happen on different processes (This will matter in the next diff when we render our events onto Perfetto). Differential Revision: D76433477
thomasywang
force-pushed
the
export-D76433477
branch
from
478ef8f to
a40d765
Compare
Summary: Previously we relied on matching a hardcoded abstract name for a unix socket to determine if the message was sent by the client. This does not work in non-linux. What we will do instead is determine if a message was sent by the client based on whether or not the src proxy address is different than the local proxy address. To make this work we do need to remove our logic for using an egress sender (which is currently unused) to send a forward message to the other proxy which then forwards it to the actual recipient and will just send directly to the recipient. That is if the controller is sending the client a message instead of going from controller -> client_proxy -> client we will go directly from controller -> client. This is because client doesn't actually run in a separate process anymore and doesn't actually have a separate proxy, and if we were to set this up this would require more work because we would also need some way to configure it such that only one proxy sends events to the event loop whereas all other proxy forwards messages to that proxy. We can file a follow up task if need be but in the meantime this diff solves our problems very simply without creating any new problems Differential Revision: D76526071
…#250) Summary: Pull Request resolved: pytorch-labs#250 We have been treating the entire message send & recv as a single event but this doesn't really make sense since each of these should have their own duration (sending -> in flight -> receiving), and they happen on different processes (This will matter in the next diff when we render our events onto Perfetto). Differential Revision: D76433477
|
This pull request was exported from Phabricator. Differential Revision: D76433477 |
thomasywang
force-pushed
the
export-D76433477
branch
from
a40d765 to
a24e3b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We have been treating the entire message send & recv as a single event but this doesn't really make sense since each of these should have their own duration (sending -> in flight -> receiving), and they happen on different processes (This will matter in the next diff when we render our events onto Perfetto).
Differential Revision: D76433477