Change accumulator releated signatures #216
Open
+506
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76357417 |
|
This pull request was exported from Phabricator. Differential Revision: D76357417 |
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Jun 13, 2025
Summary: Pull Request resolved: pytorch-labs#216 This diff is a prep diff for D76156297. Specifically, it does the following: 1. Add a `struct ReducerSpec` to replace the `64` reducer typehash. The main purpose of this struct is to add a new `builder_params` field, so we can argument the accumulator, with it, serialize it, and then send to comm actor, so comm actor can instantiate the reducer with this info. 2. Make some methods in `trait Accumulator` and `trait CommReducer` fallible. This is required by the python accumulator, because it does pickling and thus fallible. 3. Add a `typehash_f` field to `ReducerFactory`, which can be used to calculate the typehash directly. Differential Revision: D76357417
|
This pull request was exported from Phabricator. Differential Revision: D76357417 |
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Jun 16, 2025
Summary: Pull Request resolved: pytorch-labs#216 This diff is a prep diff for D76156297. Specifically, it does the following: 1. Add a `struct ReducerSpec` to replace the `64` reducer typehash. The main purpose of this struct is to add a new `builder_params` field, so we can argument the accumulator, with it, serialize it, and then send to comm actor, so comm actor can instantiate the reducer with this info. 2. Make some methods in `trait Accumulator` and `trait CommReducer` fallible. This is required by the python accumulator, because it does pickling and thus fallible. 3. Add a `typehash_f` field to `ReducerFactory`, which can be used to calculate the typehash directly. Reviewed By: mariusae Differential Revision: D76357417
…h-labs#260) Summary: Pull Request resolved: pytorch-labs#260 This diff exposes `PortRef` and `OncePortRef` to the python side, and use them where it can instead of `PortId`. This change makes it easier to implement `open_accum_port` on the python side, since we need to pass the reducer related info over from `PortRef`. Another benefit from this diff is now we can differentiate whether the response port in `PythonMessage` is `OncePortRef` or not, and implement the Bind/Unbind accordingly. Differential Revision: D76565833
Differential Revision: D76305562
Summary: Pull Request resolved: pytorch-labs#216 This diff is a prep diff for D76156297. Specifically, it does the following: 1. Add a `struct ReducerSpec` to replace the `64` reducer typehash. The main purpose of this struct is to add a new `builder_params` field, so we can argument the accumulator, with it, serialize it, and then send to comm actor, so comm actor can instantiate the reducer with this info. 2. Make some methods in `trait Accumulator` and `trait CommReducer` fallible. This is required by the python accumulator, because it does pickling and thus fallible. 3. Add a `typehash_f` field to `ReducerFactory`, which can be used to calculate the typehash directly. Reviewed By: mariusae Differential Revision: D76357417
|
This pull request was exported from Phabricator. Differential Revision: D76357417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D76357417