Fix python logs in asyncio code not showing up in scuba #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75957462 |
eliothedeman
force-pushed
the
export-D75957462
branch
from
6e159f7 to
3a5e0fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75957462 |
eliothedeman
force-pushed
the
export-D75957462
branch
from
3a5e0fa to
e75e278
Compare
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
force-pushed
the
export-D75957462
branch
2 times, most recently
from
f04f1e7 to
4f0b525
Compare
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
force-pushed
the
export-D75957462
branch
from
4f0b525 to
7bd3f60
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75957462 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D75957462 |
|
This pull request was exported from Phabricator. Differential Revision: D75957462 |
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Pull Request resolved: pytorch-labs#155 Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
force-pushed
the
export-D75957462
branch
from
7bd3f60 to
c279f82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75957462 |
eliothedeman
force-pushed
the
export-D75957462
branch
from
c279f82 to
19b622b
Compare
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Pull Request resolved: pytorch-labs#155 Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
force-pushed
the
export-D75957462
branch
from
19b622b to
78ff440
Compare
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
force-pushed
the
export-D75957462
branch
from
78ff440 to
e5ed92f
Compare
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
force-pushed
the
export-D75957462
branch
from
e5ed92f to
c8925f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75957462 |
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
|
This pull request was exported from Phabricator. Differential Revision: D75957462 |
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Pull Request resolved: pytorch-labs#155 Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
force-pushed
the
export-D75957462
branch
from
c8925f3 to
536af59
Compare
…#155) Summary: Pull Request resolved: pytorch-labs#155 Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
|
This pull request was exported from Phabricator. Differential Revision: D75957462 |
eliothedeman
force-pushed
the
export-D75957462
branch
from
536af59 to
1d2ea28
Compare
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
eliothedeman
added a commit
to eliothedeman/monarch
that referenced
this pull request
Jun 10, 2025
…#155) Summary: Because we are running our python asyncio event loop on an os thread that tokio doesn't manage, we need to manually propagate our context and create a span while our code is running. This diff adds some helper functions to manually enter and exit a span whenever actor based asyncio code is running. Reviewed By: dulinriley Differential Revision: D75957462
|
This pull request has been merged in 7d62658. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D75957462