Skip to content

add prefill/forward causal-1d-conv #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Conversation

thoangtrvn
Copy link
Contributor

This is one of a sequence of PRs to provide Triton kernel for causal-1d-conv which is used in Mamba model. It uses a different approach than the one implemented in CUDA.

CUDA code: https://github.com/Dao-AILab/causal-conv1d/tree/main

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 15, 2025
Copy link
Contributor

@lessw2020 lessw2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, though I know very little about mamba.
Nice to see a full training kernel (i.e. with backward pass support).

@lessw2020 lessw2020 merged commit 5a7f717 into pytorch-labs:main Mar 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants