Skip to content

Add timing output to subprocess commands in make.py #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

alanJoshiGeorge
Copy link

No description provided.

Copilot

This comment was marked as outdated.

@einarf einarf requested a review from pushfoo June 10, 2025 15:45
@einarf
Copy link
Member

einarf commented Jun 14, 2025

@alanJoshiGeorge Do you know how to proceed? If not .. scream and we'll help.

@einarf einarf requested a review from Copilot June 15, 2025 20:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds timing measurement to the subprocess command execution in make.py.

  • Introduces time.perf_counter to measure execution time.
  • Formats and prints the elapsed time in hours, minutes, and seconds.

@einarf
Copy link
Member

einarf commented Jun 15, 2025

Just do a python make.py format to sort the imports and this is good 👍

@pushfoo
Copy link
Member

pushfoo commented Jun 15, 2025

I'm fine with it as-is (post-./make.py format):

  • There may be a timezone issue now and then
  • Python 3.13's perf_counter is a monotonic counter which avoids them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants