Skip to content

Yet another attempt to fix list.__add__ #8293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 15, 2022
Merged

Yet another attempt to fix list.__add__ #8293

Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dfa7f7c
naive attempt
Akuli Jul 13, 2022
57dba4a
ignore
Akuli Jul 13, 2022
ad88f65
overload
Akuli Jul 13, 2022
de75e91
add comment
Akuli Jul 13, 2022
8d9e736
add test case
Akuli Jul 13, 2022
eb2e48c
Update stdlib/builtins.pyi
Akuli Jul 13, 2022
292d4e2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 13, 2022
c74e86c
fix test
Akuli Jul 13, 2022
5a6ae82
Update test_cases/stdlib/builtins/test_list.py
Akuli Jul 13, 2022
977b903
actually fixening the test fix
Akuli Jul 13, 2022
612b39e
add a bit more to test
Akuli Jul 14, 2022
5a81698
fix the test case once again
Akuli Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,8 +986,12 @@ class list(MutableSequence[_T], Generic[_T]):
@overload
def __setitem__(self, __s: slice, __o: Iterable[_T]) -> None: ...
def __delitem__(self, __i: SupportsIndex | slice) -> None: ...
# Overloading looks unnecessary, but is needed to work around complex mypy problems
@overload
def __add__(self, __x: list[_T]) -> list[_T]: ...
def __iadd__(self: Self, __x: Iterable[_T]) -> Self: ...
@overload
def __add__(self, __x: list[_S]) -> list[_S | _T]: ...
def __iadd__(self: Self, __x: Iterable[_T]) -> Self: ... # type: ignore
def __mul__(self, __n: SupportsIndex) -> list[_T]: ...
def __rmul__(self, __n: SupportsIndex) -> list[_T]: ...
def __imul__(self: Self, __n: SupportsIndex) -> Self: ...
Expand Down