Skip to content

Fix aiofiles type definitions #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Conversation

moriyoshi
Copy link
Contributor

No description provided.

moriyoshi added a commit to moriyoshi/starlette that referenced this pull request Oct 14, 2020
JayH5 pushed a commit to encode/starlette that referenced this pull request Oct 14, 2020
* Add type: ignore to make mypy happier

* Tentatively ignore type checking failure until the following patch gets merged

python/typeshed#4650
@moriyoshi
Copy link
Contributor Author

moriyoshi commented Oct 15, 2020

Can anyone in this project take a look into this?

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. LGTM, but one optional suggestion below.

@achimnol
Copy link

I'm also encountering this issue and waiting for the fix to be deployed with mypy!

@srittau srittau merged commit bad9701 into python:master Oct 23, 2020
@moriyoshi moriyoshi deleted the fix-aiofile-types branch October 24, 2020 03:22
hidraco added a commit to hidraco/starlette that referenced this pull request Apr 21, 2022
* Add type: ignore to make mypy happier

* Tentatively ignore type checking failure until the following patch gets merged

python/typeshed#4650
dudleyhunt86 added a commit to dudleyhunt86/starlette-develop-with-python that referenced this pull request Oct 7, 2022
* Add type: ignore to make mypy happier

* Tentatively ignore type checking failure until the following patch gets merged

python/typeshed#4650
azurelotus06 added a commit to azurelotus06/starlette that referenced this pull request Jun 27, 2024
* Add type: ignore to make mypy happier

* Tentatively ignore type checking failure until the following patch gets merged

python/typeshed#4650
github-actions bot pushed a commit to Kludex/jik that referenced this pull request Aug 16, 2024
* Add type: ignore to make mypy happier

* Tentatively ignore type checking failure until the following patch gets merged

python/typeshed#4650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants