add iterator methods to lxml #1647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested changes
Oct 4, 2017
| @@ -17,23 +17,67 @@ _DictAnyStr = Union[Dict[str, str], Dict[bytes, bytes]] | |||
| _Dict_Tuple2AnyStr_Any = Union[Dict[Tuple[str, str], Any], Tuple[bytes, bytes], Any] | |||
|
|
|||
|
|
|||
| class ElementChildIterator(Iterator['_Element']): | |||
| class _ElementMatchIterator(Iterator['_Element']): | |||
| def __iter__(self) -> '_ElementMatchIterator': ... | |||
There was a problem hiding this comment.
All of these overridden __iter__/__next__ methods seem to be redundant. I think you can just write most of these classes like class _ElementMatchIterator(Iterator[_Element]): .... __iter__ and __next__ will be inherited correctly. In that case, leave no blank space between the classes.
|
with #1664 the lxml stubs will be removed. |
|
The lxml stubs are now gone. Feel free to submit this change to https://github.com/JelleZijlstra/lxml-stubs instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a couple of iterators and iterator methods to lxml. Nevertheless, many methods from
lxmlare still missing, cf. #525.Both python 3 test suits pass.