Add Path.copy_into for 3.14
#13998
Closed
Add Path.copy_into for 3.14
#13998
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| pth = MyCustomPath.from_uri("file:///tmp/abc.txt") | ||
| # If the destination is a non-Path, it should default to a base Path. |
There was a problem hiding this comment.
This seems the opposite of the behavior the tests show.
There was a problem hiding this comment.
Yeah, originally had different behavior until I corrected it - missed this comment.
This comment has been minimized.
This comment has been minimized.
|
Moving back to draft until I can fix issues. |
|
The mypy-primer diff is the opposite of #13985, very suspicious. |
max-muoto
force-pushed
the
add-pathlib-copy_into
branch
from
5e8d1bf to
cf5969d
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
copy_intoforPath, there is some slightly interesting behavior around the fact in that if a destination that is aPurePaththan than the path will return will match that class - otherwisetype(self)is used. As a result, added a test to ensure we maintain this behavior.